On 03/21/2017 04:23 PM, Laine Stump wrote:
I found these while trying out some other code I decided not to use (I was going to add more attributes to the <link> element, virNetDevIfLink, and virNetDevGetLinkInfo(), but then decided not to for now (in case Michal has a different idea of the meaning of "link" than, e.g., iproute's "ip link" command). The first two taken together actually have a very positive impact - they make the output of "virsh nodedev-dumpxml" much more informative when run as non-root. Laine Stump (3): util: use AF_UNIX family (not AF_PACKET) for ioctl sockets util: allow retrieving ethtool features when unprivileged network: remove unused typedef for networkDnsmasqLeaseFileNameFunc src/network/bridge_driver.h | 2 -- src/util/virnetdev.c | 8 +------- src/util/virnetdevip.c | 2 +- 3 files changed, 2 insertions(+), 10 deletions(-)
ACK series but see my comment to 1/3 before pushing please. Michal -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
