On 03/16/2017 01:14 PM, Andrea Bolognani wrote: > We want pcie-root-ports to be used when available in QEMU, > but at the same time we need to ensure that hosts running > older QEMU releases keep working and that the user can > override the default at any time. > > Add a comment for the original pcie-root-port test cases > to make it clear how these new test cases are different. > --- > Changes from v1: > > * Don't change existing test cases; > * Only test the new feature once. ACK. (every time I see a new test added to qemuxml2argvtest and qemuxml2xmltest it makes me want them to share a common list of DO_TEST() invocations so that all that hard work you did to bring them in sync doesn't get trampled.) (Nudge nudge, wink wink. Know what I mean, mate?) -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list