Re: [PATCH v3 04/17] qemuBuildMemoryBackendStr: Reorder args and update comment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 03/09/2017 11:06 AM, Michal Privoznik wrote:
> Frankly, this function is one big mess. A lot of arguments,
> complicated behaviour. It's really surprising that arguments were
> in random order (input and output arguments were mixed together),
> the documentation was outdated, the description of return values
> was bogus.
> 
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
>  src/qemu/qemu_command.c | 54 +++++++++++++++++++++++++++----------------------
>  src/qemu/qemu_command.h | 12 +++++------
>  src/qemu/qemu_hotplug.c |  4 ++--
>  3 files changed, 38 insertions(+), 32 deletions(-)
> 

ACK

John

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux