Re: [PATCH] docs: document virt-host-validate bhyve support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



  Martin Kletzander wrote:

> On Sat, Mar 11, 2017 at 10:13:00PM +0400, Roman Bogorodskiy wrote:
> >Add an entry about virt-host-validate bhyve support and
> >update the driver's page.
> >---
> > docs/drvbhyve.html.in | 13 ++++++++++++-
> > docs/news.xml         | 10 +++++++++-
> > 2 files changed, 21 insertions(+), 2 deletions(-)
> 
> The good thing about the new news file layout is that we can express
> freely what is the feature that was added and we don't have to
> copy-paste the restricted commit messages.  So I, personally, like to
> have nicely formatted sentences in the summary (well, I like that even
> in the commit messages sometimes, but that's another story).  I would go
> with:
> 
>   "Add(ed) bhyve support to the virt-host-validate tool"
> 
> or even:
> 
>   "The virt-host-validate tool now supports bhyve hypervisor"
> 
> for the summary and I would remove the description.  But that's pretty
> subjective, so I'll leave the final decision up to you, just wanted to
> put it out there.
> 
> ACK

This looks like a valid point to me, and I like the latter sentence better.
I've pushed that version, thanks!

Roman Bogorodskiy

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux