On Thu, Jun 25, 2009 at 03:43:12PM +0200, Daniel Veillard wrote: > On Thu, Jun 25, 2009 at 09:29:48AM +0900, Tatsuro Enokura wrote: > > Hi Dan, > > > > Tatsuro Enokura wrote: > >>> I don't think that is neccessary. You'll only invoke > >>> virDomainGetSecurityLabel > >>> if virNodeGetSecurityModel() was asuccessfull and the returned secmodel > >>> is not the empty string. In such a scenario I'd expect the call to > >>> virDomainGetSecurityLabel() to always be successful and would want the > >>> user to see any error if it fail > >> > >> OK, I understood. > >> > >> I try your patch, works fine. > > > > If there is not problem, please commit your patch. > > This was already commited to CVS as far as I can tell, I did it about an hour ago but got distracted by lunch before I replied :-) Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list