In order to properly restore the original state of an SRIOV VF when
we're finished with it, we need to save the MAC address of the VF
itself (not just the admin MAC address for the VF that is stored in
the PF). But that can only be done when the VF is still bound to the
host's netdev driver, and we have always done the saving of device
config after the VF is already bound to vfio-pci. This patch prepares
us for adding a save of the VF's MAC by calling the function that
saves netconfig earlier in the device preparation, before we've
unbound it from the host netdev driver.
---
src/util/virhostdev.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/src/util/virhostdev.c b/src/util/virhostdev.c
index 3b5bad0..e9e2ab3 100644
--- a/src/util/virhostdev.c
+++ b/src/util/virhostdev.c
@@ -649,6 +649,14 @@ virHostdevPreparePCIDevices(virHostdevManagerPtr mgr,
}
}
+ /* Step 1.5: For non-802.11Qbh SRIOV network devices, save the
+ * current device config
+ */
+ for (i = 0; i < nhostdevs; i++) {
+ if (virHostdevSaveNetConfig(hostdevs[i], mgr->stateDir) < 0)
+ goto cleanup;
+ }
+
/* Step 2: detach managed devices and make sure unmanaged devices
* have already been taken care of */
for (i = 0; i < virPCIDeviceListCount(pcidevs); i++) {
@@ -739,9 +747,6 @@ virHostdevPreparePCIDevices(virHostdevManagerPtr mgr,
* the network device, set the new netdev config */
for (i = 0; i < nhostdevs; i++) {
- if (virHostdevSaveNetConfig(hostdevs[i], mgr->stateDir) < 0)
- goto resetvfnetconfig;
-
if (virHostdevSetNetConfig(hostdevs[i], uuid) < 0)
goto resetvfnetconfig;
--
2.9.3
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
