On 03/06/2017 05:36 PM, John Ferlan wrote: > Continuing down the pile of drivers from my RFC for making a common pool > object - we're now at nwfilter (still have storage and network to go). > For reference see patch 3 of: > > http://www.redhat.com/archives/libvir-list/2017-February/msg00519.html > > This series works through the nwfilter conf adjustments. We start by > fixing a couple of API's that aren't using objects, then launch into > the repetitive type actions of moving the code into it's own module, > fixing up the "style", altering the function prototypes, and finally > using virNWFilterObj prefix for any API's in virnwfilterobj. > > John Ferlan (6): > conf: Change virNWFilterObjSaveDef to virNWFilterSaveDef > conf: Change virNWFilterObjDeleteDef to virNWFilterDeleteDef > conf: Introduce virnwfilterobj > conf: Adjust coding style for nwfilter conf sources > conf: Alter coding style of nwfilter function prototypes > conf: Use consistent function name prefixes for virnwfilterobj > > po/POTFILES.in | 1 + > src/Makefile.am | 6 +- > src/conf/nwfilter_conf.c | 498 +++++++-------------------------- > src/conf/nwfilter_conf.h | 157 +++++------ > src/conf/virnwfilterobj.c | 388 +++++++++++++++++++++++++ > src/conf/virnwfilterobj.h | 94 +++++++ > src/libvirt_private.syms | 26 +- > src/nwfilter/nwfilter_driver.c | 13 +- > src/nwfilter/nwfilter_gentech_driver.h | 2 +- > src/nwfilter/nwfilter_tech_driver.h | 2 +- > 10 files changed, 676 insertions(+), 511 deletions(-) > create mode 100644 src/conf/virnwfilterobj.c > create mode 100644 src/conf/virnwfilterobj.h > ACK series, but please read my comment to 6/6 before pushing. Michal -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
