Feedback from the initial pass at RFC for making a common pool object was that it got really confusing trying to manage the multitude of changes. See patch 3 of the series: http://www.redhat.com/archives/libvir-list/2017-February/msg00519.html So while I figure out what it'll take to make a better object framework, I figure I could start splitting out things a bit to make future work a bit easier to understand. Also rather than trying to do them all in one massive series, I'm working through shorter series contained to each of the driver conf's - this one is for interface and if follows the same pattern as node device. John Ferlan (4): conf: Introduce virinterfaceobj conf: Adjust coding style for interface conf sources conf: Use consistent function name prefixes for virinterfaceobj conf: Alter coding style of interface function prototypes po/POTFILES.in | 1 + src/Makefile.am | 3 +- src/conf/interface_conf.c | 239 ++++++++------------------------ src/conf/interface_conf.h | 60 ++------ src/conf/virinterfaceobj.c | 217 +++++++++++++++++++++++++++++ src/conf/virinterfaceobj.h | 84 +++++++++++ src/interface/interface_backend_netcf.c | 1 + src/interface/interface_backend_udev.c | 1 + src/libvirt_private.syms | 19 +-- src/test/test_driver.c | 26 ++-- 10 files changed, 396 insertions(+), 255 deletions(-) create mode 100644 src/conf/virinterfaceobj.c create mode 100644 src/conf/virinterfaceobj.h -- 2.9.3 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list