On Mon, Feb 27, 2017 at 07:05:24PM +0100, Markus Armbruster wrote: > Eduardo Habkost <ehabkost@xxxxxxxxxx> writes: > > > The "hotplugged" property is user visible, but it was never meant > > to be set by the user. There are probably multiple ways to break > > or crash device code by overriding the property. For example, we > > recently fixed a crash in rtc_set_memory() related to the > > property (commit 26ef65beab852caf2b1ef4976e3473f2d525164d). > > > > There has been some discussion about making management software > > use "hotplugged=on" on migration, to indicate devices that were > > hotplugged in the migration source. There were other suggestions > > to address this, like including the "hotplugged" field in the > > migration stream instead of requiring it to be set propertly. > > > > Whatever solution we choose in the future, this patch disables > > setting "hotplugged" explicitly in the command-line by now, > > because the ability to set the property is unused, untested, and > > undocumented. > > > > Signed-off-by: Eduardo Habkost <ehabkost@xxxxxxxxxx> > > I figure this is the safe thing to do for 2.9. > > Reviewed-by: Markus Armbruster <armbru@xxxxxxxxxx> Thanks. I have merged it to my "machine" branch, and I plan to include it in a pull request next week. -- Eduardo -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
