On 03/02/2017 06:10 PM, Jim Fehlig wrote:
> On 02/08/2017 09:44 AM, Joao Martins wrote:
>> Signed-off-by: Joao Martins <joao.m.martins@xxxxxxxxxx>
>
> Since it wasn't needed before, I think it is helpful for the commit message to
> describe why the change is needed now.
True, my apologies. I should have included at least the sentence I had on the
cover letter regarding this commit (same for patch 3).
>> ---
>> src/util/virqemuagent.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/util/virqemuagent.c b/src/util/virqemuagent.c
>> index caabae0..ffb3489 100644
>> --- a/src/util/virqemuagent.c
>> +++ b/src/util/virqemuagent.c
>> @@ -333,7 +333,8 @@ qemuAgentIOProcessLine(qemuAgentPtr mon,
>> goto cleanup;
>> }
>>
>> - if (virJSONValueObjectHasKey(obj, "QMP") == 1) {
>> + if (virJSONValueObjectHasKey(obj, "QMP") == 1 ||
>> + virJSONValueObjectHasKey(obj, "execute") == 1) {
>
> And a brief comment in the code, e.g. along the lines of the commit summary.
/nods
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
