On Thu, Mar 02, 2017 at 11:10:10AM -0700, Jim Fehlig wrote: > On 02/08/2017 09:44 AM, Joao Martins wrote: > > Signed-off-by: Joao Martins <joao.m.martins@xxxxxxxxxx> > > Since it wasn't needed before, I think it is helpful for the commit message > to describe why the change is needed now. I'm open to being convinced otherwise, but I'd say that if the guest is echo'ing back commands the host sends, then the guest is broken and we shouldn't workaround that in libvirt. Or perhaps something about the hypervisor data channel over which the guest agent is running is running. Seeing data echo'd back suggests use of a PTY which has not been put into raw mode, or something like that. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
