On Thu, Mar 02, 2017 at 08:04:32AM -0500, John Ferlan wrote: > > > On 03/01/2017 07:27 PM, John Ferlan wrote: > > Alter the static functions from virNodeDev* to just nodeDev* as a visual > > cue to determine which are local or not when reading code. > > Rather than trying to respond individually to points raised... I'll just > go with one... [snip] > I can rework this patch to just do the match of more modern libvirt > techniques described in the next paragraph and drop the renaming. It's > not that important. One thing I noticed is that we don't appear to have documented our preferred naming conventions for files, struct, variables, functions, etc, in the hacking file. This is a problem because our code is not entirely consistent due to the conventions having changed over time. This missing doc something we should fix, so that in future we can avoid needing to debate it and just point to the documented conventions. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
