On Wed, Mar 01, 2017 at 19:27:15 -0500, John Ferlan wrote: > Alter the static functions from virNodeDev* to just nodeDev* as a visual > cue to determine which are local or not when reading code. > > Cleanup spacing between functions, function defs, etc. to match more modern > techniques used in libvirt > > Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx> > --- > src/conf/node_device_conf.c | 476 +++++++++++++++++++++++--------------------- > src/conf/virnodedeviceobj.c | 128 ++++++------ > 2 files changed, 322 insertions(+), 282 deletions(-) > > diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c > index bc36527..09e815a 100644 > --- a/src/conf/node_device_conf.c > +++ b/src/conf/node_device_conf.c > @@ -72,9 +72,9 @@ VIR_ENUM_IMPL(virNodeDevDRM, VIR_NODE_DEV_DRM_LAST, > "render") > > static int > -virNodeDevCapsDefParseString(const char *xpath, > - xmlXPathContextPtr ctxt, > - char **string) > +nodeDevCapsDefParseString(const char *xpath, > + xmlXPathContextPtr ctxt, > + char **string) Please don't remove the vir prefix. The coding style tries to converge to having them everywhere.
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list