On Mon, 27 Feb 2017 10:55:26 +0100 Erik Skultety <eskultet@xxxxxxxxxx> wrote: > On Fri, Feb 24, 2017 at 11:10:00AM -0700, Alex Williamson wrote: > > On Mon, 20 Feb 2017 15:28:13 +0100 > > Erik Skultety <eskultet@xxxxxxxxxx> wrote: > > > > > since the original v2 [1]: > > > - resolved a few merge conflicts caused by @9d92f533 which refactored out some > > > duplicate code which eventually lead to dropping patch 14/18 from the original > > > series due to being unnecessary > > > - rebased onto fresh HEAD > > > > > > [1] https://www.redhat.com/archives/libvir-list/2017-February/msg00739.html > > > > > > Erik Skultety (18): > > > util: Introduce new module virmdev > > > conf: Introduce new hostdev device type mdev > > > conf: Introduce new address type mdev > > > conf: Update XML parser, formatter, and RNG schema to support mdev > > > conf: Introduce virDomainHostdevDefPostParse > > > conf: Add post parse code for mdevs to virDomainHostdevDefPostParse > > > security: dac: Enable labeling of vfio mediated devices > > > security: selinux: Enable labeling of vfio mediated devices > > > conf: Enable cold-plug of a mediated device > > > qemu: Assign PCI addresses for mediated devices as well > > > hostdev: Maintain a driver list of active mediated devices > > > hostdev: Introduce a reattach method for mediated devices > > > qemu: cgroup: Adjust cgroups' logic to allow mediated devices > > > qemu: Bump the memory locking limit for mdevs as well > > > qemu: Format mdevs on qemu command line > > > test: Add some test cases for our test suite regarding the mdevs > > > docs: Document the new hostdev and address type 'mdev' > > > news: Update the NEWS.xml about the new mdev feature > > > > > > docs/formatdomain.html.in | 48 ++- > > > docs/news.xml | 9 + > > > docs/schemas/domaincommon.rng | 26 ++ > > > po/POTFILES.in | 1 + > > > src/Makefile.am | 1 + > > > src/conf/device_conf.h | 1 + > > > src/conf/domain_conf.c | 203 ++++++++++-- > > > src/conf/domain_conf.h | 9 + > > > src/libvirt_private.syms | 20 ++ > > > > I don't understand how these get generated, so I won't suggest where > > they should be added, but a usb test fails for me without adding > > these to this syms file: > > > > Hmm, weird, nothing fails for me, even rebased onto the current master. > Anyhow, I checked that we indeed put these generated methods into the .syms > file which I didn't know (never had a problem with that), but I'll fix it. The error occurs for me on the make rpm target with the following: FAIL: virusbtest ================ /home/alwillia/rpmbuild/BUILD/libvirt-3.1.0/tests/.libs/lt-virusbtest: symbol lookup error: /home/alwillia/rpmbuild/BUILD/libvirt-3.1.0/tests/.libs/virusbmock.so: undefined symbol: virMediatedDeviceModelTypeFromString FAIL virusbtest (exit status: 127) I'm based on the v3.1.0-rc1 tag plus this series. Thanks, Alex -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
