Arguably though, function returning only on success is a very interesting, although quite impractical concept. Also, the errno isn't and shouldn't be preserved in this case, since the errno can be directly fed to the virReportSystemError. Signed-off-by: Erik Skultety <eskultet@xxxxxxxxxx> --- Pushed as trivial. src/util/virfile.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/util/virfile.c b/src/util/virfile.c index 6ba67bf..41cdca9 100644 --- a/src/util/virfile.c +++ b/src/util/virfile.c @@ -1820,7 +1820,8 @@ virFileIsDir(const char *path) * virFileExists: Check for presence of file * @path: Path of file to check * - * Returns if the file exists. Preserves errno in case it does not exist. + * Returns true if the file exists, false if it doesn't, setting errno + * appropriately. */ bool virFileExists(const char *path) -- 2.10.2 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
