The situation covered by the removed code will not ever happen.
This code is called only while starting a new QEMU process where
the capabilities where already checked and while attaching to
existing QEMU process where we don't even detect the iothreads.
Signed-off-by: Pavel Hrdina <phrdina@xxxxxxxxxx>
---
src/qemu/qemu_process.c | 25 -------------------------
1 file changed, 25 deletions(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 4710d4ca28..522f49d8b7 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -2101,31 +2101,6 @@ qemuProcessDetectIOThreadPIDs(virQEMUDriverPtr driver,
int ret = -1;
size_t i;
- if (!virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_OBJECT_IOTHREAD)) {
- /* The following check is because at one time a domain could
- * define iothreadids and start the domain - only failing the
- * capability check when attempting to add a disk. Because the
- * iothreads and [n]iothreadids were left untouched other code
- * assumed it could use the ->thread_id value to make thread_id
- * based adjustments (e.g. pinning, scheduling) which while
- * succeeding would execute on the calling thread.
- */
- if (vm->def->niothreadids) {
- for (i = 0; i < vm->def->niothreadids; i++) {
- /* Check if the domain had defined any iothreadid elements
- * and supply a VIR_INFO indicating that it's being removed.
- */
- VIR_INFO("IOThreads not supported, remove iothread id '%u'",
- vm->def->iothreadids[i]->iothread_id);
- virDomainIOThreadIDDefFree(vm->def->iothreadids[i]);
- }
- /* Remove any trace */
- VIR_FREE(vm->def->iothreadids);
- vm->def->niothreadids = 0;
- }
- return 0;
- }
-
/* Get the list of IOThreads from qemu */
if (qemuDomainObjEnterMonitorAsync(driver, vm, asyncJob) < 0)
goto cleanup;
--
2.11.1
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
