On Thu, Jun 18, 2009 at 10:56:44PM +0000, David Lutterkort wrote: > On Thu, 2009-06-18 at 18:10 +0100, Daniel P. Berrange wrote: > > > I don't see that that buys us anything that we wouldn't have with > > > > > > <ip type='ipv4' address='122.0.0.3' prefix='24'/> > > > <ip type='ipv4' address='24.24.224.4' prefix='24'/> > > > <ip type='ipv6' address='2001:23::2' prefix='48'/> > > > <ip type='ipv6' address='fe:33:55::33' prefix='64'/> > > > <ipx address='2423.4521.66.3.252.'/> > > > > If you do this, then you'll need an explicit element to turn on / off > > IPv4 or IPv6 addressing for the inteface as whole. ie to stop the > > automatic addition of a link-local address. > > That should be stated explicitly, not implied by having an empty > <address/> tag. IMHO that results in a bad structure, because its anot associating the related info together, eg having an separate element to turn on/off IPV6, and then listing addresses: <address family='ipv6'/> <ip type='ipv6' address='2001:23::2' prefix='48'/> <ip type='ipv6' address='fe:33:55::33' prefix='64'/> vs having the direct association <address family='ipv6'> <ip address='2001:23::2' prefix='48'/> <ip address='fe:33:55::33' prefix='64'/> </address> the latter removes the redundancy from specifying address family in multiple places > > By having the container, for each family, the prescense or not of the > > container can define whether that address family is enabled for that > > inteface. > > What would 'enabling an address family for an interface' do ? Whatever > it does should probably be stated explicitly. That's really protocol specific, but it will typically enable some local address auto-config by the kernel. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list