Re: [PATCH 2/4] conf: Fix libvirtd free() segfault if virDomainChrSourceDefNew(...) fails

[Laine Stump <laine@xxxxxxxxx>]

On 02/09/2017 09:13 AM, Marc Hartmayer wrote:
> If virDomainChrSourceDefNew(xmlopt) fails, it will lead to free()ing
> the uninitialized pointer bus. The fix for this is to initialize bus
> with NULL.
>
> Signed-off-by: Marc Hartmayer <mhartmay@xxxxxxxxxxxxxxxxxx>
> Reviewed-by: Boris Fiuczynski <fiuczy@xxxxxxxxxxxxxxxxxx>
> Reviewed-by: Bjoern Walk <bwalk@xxxxxxxxxxxxxxxxxx>
> ---
>   src/conf/domain_conf.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index c06b128..ef883b5 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c
> @@ -13307,7 +13307,7 @@ virDomainRedirdevDefParseXML(virDomainXMLOptionPtr xmlopt,
>   {
>       xmlNodePtr cur;
>       virDomainRedirdevDefPtr def;
> -    char *bus, *type = NULL;
> +    char *bus = NULL, *type = NULL;
>       int remaining;
>   
>       if (VIR_ALLOC(def) < 0)


ACK

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list