Re: [PATCH 11/11] qemuDomainNamespaceSetupDisk: Simplify disk check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 08, 2017 at 11:37:14 +0100, Michal Privoznik wrote:
> Firstly, instead of checking for next->path the
> virStorageSourceIsEmpty() function should be used which also
> takes disk type into account.
> Secondly, not every disk source passed has the correct type set
> (due to our laziness). Therefore, instead of checking for
> virStorageSourceIsBlockLocal() and also S_ISBLK() the former can
> be refined to just virStorageSourceIsLocalStorage().
> 
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
>  src/qemu/qemu_domain.c | 11 ++++-------
>  1 file changed, 4 insertions(+), 7 deletions(-)

ACK

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux