On 02/08/2017 01:23 PM, Peter Krempa wrote: > On Wed, Feb 08, 2017 at 11:37:07 +0100, Michal Privoznik wrote: >> Nearly all of these functions look the same. Except for a >> different virSecurityManager API call. There is no need to copy >> paste the code when we can use macros to generate it. >> >> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> >> --- >> src/qemu/qemu_security.c | 179 ++++++++++++----------------------------------- >> 1 file changed, 44 insertions(+), 135 deletions(-) > > NACK, please don't partialy define function with macros. > Why not? What is the downside? Michal -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
