On Wed, 2017-02-01 at 20:25 +0400, Roman Bogorodskiy wrote: > Like it usually happens, I fixed one thing and broke another: > in 803966c76 address allocation was fixed for SATA disks, but > broke that for virtio disks, because it dropped disk address > assignment completely. It's not needed for SATA disks anymore, > but still needed for the virtio ones. > > Bring that back and add a couple of tests to make sure it won't > happen again. I didn't actually test this[1], but both the code and the tests look reasonable enough, plus 'make check' and 'make syntax-check' are all green[2] on FreeBSD, so: ACK [1] Can you run bhyve guests inside a FreeBSD KVM guest? [2] Well, mostly. We really should fix qemuxml2argvtest once and for all, and it looks like we're sooo close now! -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
