On Thu, Jun 18, 2009 at 12:42:15PM +0100, Daniel P. Berrange wrote: > A recent patch made the qemudGetCapabilities() method blow away and > re-create the QEMU driver's capabilities object. Unfortunately it did > not re-initialize the security model capabilities data. It also left > open the possibility that the QEMU driver could be left with no active > capabilities object at all in the case of OOM. Thus, this patch . > > - Splits the security capabilities init code out to be callable > independantly of init of the security driver itself > - Makes qemudGetCapabilities repopopulate security driver info > - Don't free the existing capabilities object until we have > successfully created a new one Looks fine, and should fix one of the bugs reported recently, ACK Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list