On 02/07/2017 10:59 AM, Martin Kletzander wrote: > On Fri, Jan 20, 2017 at 10:42:46AM +0100, Michal Privoznik wrote: >> After previous commit this has become redundant step. >> Also setting up devices in namespace and setting their label >> later on are two different steps and should be not done at once. >> >> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> >> --- >> src/qemu/qemu_domain.c | 112 >> +------------------------------------------------ >> 1 file changed, 2 insertions(+), 110 deletions(-) >> >> diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c >> index c67604222..0f45f753e 100644 >> --- a/src/qemu/qemu_domain.c >> +++ b/src/qemu/qemu_domain.c >> @@ -7707,67 +7655,11 @@ qemuDomainDetachDeviceUnlinkHelper(pid_t pid >> ATTRIBUTE_UNUSED, >> >> >> static int >> -qemuDomainDetachDeviceUnlink(virQEMUDriverPtr driver, >> +qemuDomainDetachDeviceUnlink(virQEMUDriverPtr driver ATTRIBUTE_UNUSED, >> virDomainObjPtr vm, >> - virDomainDeviceDefPtr dev, >> + virDomainDeviceDefPtr dev ATTRIBUTE_UNUSED, > > Any reason for keeping these unused attributes here? Your call on > removing them (from caller as well, of course). ACK either way. As mentioned in previous e-mail, I have another patch set ready that goes on the top of this and removes couple of unused variables/arguments (mostly because I'm fixing another bug by calling qemuDomainNamespaceSetupDisk() from a place where just virStorageSourcePtr is available. So stay tuned :-) Michal -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
