On Sun, 2017-02-05 at 16:52 +0400, Roman Bogorodskiy wrote: [...] > + <change> > + <summary> > + bhyve: change address allocation schema for SATA disks > + </summary> The indentation is all wrong, here and below. Please indent using only spaces and make sure the result matches existing entries; be also mindful of line length. > + <description> > + Previously, the bhyve driver assigned PCI addresses to SATA disks directly > + rather than assigning that to a controller and using SATA addresses for disks. > + It was implemented this way because bhyve has no notion of an explicit SATA > + controller. Aside: does this mean there is an implicit, default SATA controller? How would that work otherwise? > However, this doesn't go inline with the internal libvirt model, "However, as this doesn't match libvirt's understanding of disk addresses, [...]" or something along those lines. > + it was changed for the bhyve driver to follow the common schema and > + have PCI addresses for SATA controllers and SATA addresses for disks. If you're having > + issues because of this, it's recommended to edit the domain's XML and remove > + <address type='xml'> from the <disk> elements with s/xml/pci/ here, I assume. > + <target bus="sata"/> and let libvirt regenerate it properly. s/"/'/g to match the above and what libvirt actually uses ;) -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
