On Sat, Jan 28, 2017 at 10:03:13AM +0100, Michal Privoznik wrote:
On 26.01.2017 15:38, Martin Kletzander wrote:On Wed, Jan 25, 2017 at 03:53:20PM +0100, Martin Kletzander wrote:Due to our APIs not copying various pointers, we need to carry it around on the side and just supply it every time it is needed. Otherwise it will not work with both --live and --config options. Signed-off-by: Martin Kletzander <mkletzan@xxxxxxxxxx> --- src/qemu/qemu_driver.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-)Scratch this, this needs some fixes as well, but trivial ones, so this whole series is on branch blkdeviotune on my github now https://github.com/nertpinx/libvirt/tree/blkdeviotuneWhile it would be nice to send the patches to the list as another version, this has undergone more rounds than needed. ACK to the patches on your branch. There are still some problems (e.g. in "qemu: Don't lose group_name" - we firstly free() and then try to strdup() which can lead to losing the original value if strdup() fails), but those can be fixed after your patches are pushed.
You know what, you're right, I was trying to push this just to get rid of it, but why couldn't we do this the tight way, right? I rebase the branch on master, dropped the "don't lose group_name" commit and I'll resend that one. I'll also push the rest, so it's just one clean patch and not resends of stuff. Who knows how many other things we'll end up changing when hunting down the one issue.
Michal
Attachment:
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
