Re: [PATCH 5/5] qemu: Add better message for some invalid block I/O settings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 01/25/2017 04:16 AM, Martin Kletzander wrote:
> For example when both total_bytes_sec and total_bytes_sec_max are set,
> but the former gets cleaned due to new call setting, let's say,
> read_bytes_sec, we end up with this weird message for the command:
> 
>  $ virsh blkdeviotune fedora vda --read-bytes-sec 3000
>  error: Unable to change block I/O throttle
>  error: unsupported configuration: value 'total_bytes_sec_max' cannot be set if 'total_bytes_sec' is not set
> 
> So let's make it more descriptive.  This is how it looks after the change:
> 
>  $ virsh blkdeviotune fedora vda --read-bytes-sec 3000
>  error: Unable to change block I/O throttle
>  error: unsupported configuration: cannot reset 'total_bytes_sec' when 'total_bytes_sec_max' is set
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1344897
> 
> Signed-off-by: Martin Kletzander <mkletzan@xxxxxxxxxx>
> ---
>  src/qemu/qemu_driver.c | 46 +++++++++++++++++++++++++++++++---------------
>  1 file changed, 31 insertions(+), 15 deletions(-)
> 

At least this is easier with those macros... I'm fine with the error
message adjustments here - although I thought QEMU checked the various
inconsistencies and messaged based on that (perhaps something I checked
when using the qemu command line instead of via virsh - cannot recall now).

ACK,

John

oh and before I forget... Could you please update:

https://bugzilla.redhat.com/show_bug.cgi?id=1336564

to indicate which commit fixes the issues for group name. Thanks and
sorry for the mess.

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux