On Mon, Jun 15, 2009 at 06:11:07PM -0400, Cole Robinson wrote: > Rather than numerous instances of: > > emulator = vm->def->emulator; > if (!emulator) > emulator = virDomainDefDefaultEmulator(conn, vm->def, driver->caps); > if (!emulator) > return -1; > > Set this value at XML parse time in the domain config, so we can depend on > it for all future emulator accesses. There were unchecked accesses in the > qemu driver that were tripping up on this if no emulator was specified in > the XML, see: Okay, I had to convince myself that we were not leaking the emulator string in the end, but that looks fine. ACK Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list