Re: [PATCH v2 11/11] tests: hotplug: Test CPU hotplug with ppc64 data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 11, 2017 at 10:48:21AM +0100, Peter Krempa wrote:
> Add a positive test and few negative tests.
> ---
>  tests/qemuhotplugtest.c                            |   4 +
>  tests/qemuhotplugtestcpus/ppc64-bulk-domain.xml    |  20 +
>  tests/qemuhotplugtestcpus/ppc64-bulk-monitor.json  | 593 +++++++++++++++++++++
>  .../qemuhotplugtestcpus/ppc64-bulk-result-conf.xml |  64 +++
>  .../qemuhotplugtestcpus/ppc64-bulk-result-live.xml |  72 +++
>  5 files changed, 753 insertions(+)
>  create mode 100644 tests/qemuhotplugtestcpus/ppc64-bulk-domain.xml
>  create mode 100644 tests/qemuhotplugtestcpus/ppc64-bulk-monitor.json
>  create mode 100644 tests/qemuhotplugtestcpus/ppc64-bulk-result-conf.xml
>  create mode 100644 tests/qemuhotplugtestcpus/ppc64-bulk-result-live.xml
> 
> diff --git a/tests/qemuhotplugtest.c b/tests/qemuhotplugtest.c
> index f0817eb86..44a5e69ae 100644
> --- a/tests/qemuhotplugtest.c
> +++ b/tests/qemuhotplugtest.c
> @@ -773,6 +773,10 @@ mymain(void)
> 
>      DO_TEST_CPU_GROUP("x86-modern-bulk", 7, true, false);
>      DO_TEST_CPU_GROUP("x86-old-bulk", 7, false, false);
> +    DO_TEST_CPU_GROUP("ppc64-bulk", 24, true, false);
> +    DO_TEST_CPU_GROUP("ppc64-bulk", 15, true, true);
> +    DO_TEST_CPU_GROUP("ppc64-bulk", 23, true, true);
> +    DO_TEST_CPU_GROUP("ppc64-bulk", 25, true, true);

Even though there is only modern cpu hotplug on ppc64 I would put the modern
into the test name just to make it clear that it tests modern cpu hotplug.

ACK

Pavel

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux