Re: [PATCH] storage: Fix storage_backend probing when PARTED not installed.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 10, 2017 at 10:20:11 -0500, John Ferlan wrote:
> Commit id 'a48c674f' caused problems for systems without PARTED installed.
> 
> So move the PARTED probing code back to storage_backend_disk.c and create
> a shim within storage_backend.c to call it if WITH_STORAGE_DISK is true;
> otherwise, just return -1 with the error.
> 
> Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx>
> ---
> 
>  Reported to me internally via Peter Krempa...  Not pushing as a build
>  breaker - I'll let Peter review and ACK.

I don't really see a reason why this should be a build time dependency,
but this fixes the build for me now so ACK.

Peter

P.S: I'll post a patch that removes a build-time dependency on the
gluster cli tool soon, since it doesn't make much sense.

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux