When updating the source file in commit bd4f4d168660, I forgot
that we also store the generated plain text version in git and
didn't regenerate it.
I also missed one spot that required an additional <p> tag, so
fix both mistakes in one go.
---
Pushed as trivial.
This is the second time I have to clean up after myself today:
clearly not my best morning ever. /me pours more coffee
HACKING | 10 ++++++++++
docs/hacking.html.in | 7 +++++--
2 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/HACKING b/HACKING
index 3656411..1952856 100644
--- a/HACKING
+++ b/HACKING
@@ -14,15 +14,21 @@ General tips for contributing patches
(1) Discuss any large changes on the mailing list first. Post patches early and
listen to feedback.
+
+
(2) Official upstream repository is kept in git ("git://libvirt.org/libvirt.git")
and is browsable along with other libvirt-related repositories (e.g.
libvirt-python) online <http://libvirt.org/git/>.
+
+
(3) Patches to translations are maintained via the zanata project
<https://fedora.zanata.org/>. If you want to fix a translation in a .po file,
join the appropriate language team. The libvirt release process automatically
pulls the latest version of each translation file from zanata.
+
+
(4) Post patches using "git send-email", with git rename detection enabled. You
need a one-time setup of:
@@ -93,6 +99,8 @@ things).
(7) Make sure your patches apply against libvirt GIT. Developers only follow GIT
and don't care much about released versions.
+
+
(8) Run the automated tests on your code before submitting any changes. In
particular, configure with compile warnings set to -Werror. This is done
automatically for a git checkout; from a tarball, use:
@@ -238,6 +246,8 @@ feature or changing the output of a program.
+
+
There is more on this subject, including lots of links to background reading
on the subject, on Richard Jones' guide to working with open source projects
<http://people.redhat.com/rjones/how-to-supply-code-to-open-source-projects/>.
diff --git a/docs/hacking.html.in b/docs/hacking.html.in
index 13b3640..47475a2 100644
--- a/docs/hacking.html.in
+++ b/docs/hacking.html.in
@@ -289,8 +289,11 @@
}
</pre>
</li>
- <li>Update tests and/or documentation, particularly if you are adding
- a new feature or changing the output of a program.</li>
+
+ <li>
+ <p>Update tests and/or documentation, particularly if you are adding
+ a new feature or changing the output of a program.</p>
+ </li>
</ol>
<p>
--
2.7.4
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
