On Fri, Dec 16, 2016 at 10:11:28 +0100, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina <phrdina@xxxxxxxxxx> > --- > m4/virt-driver-libxl.m4 | 43 +++++++++++++------------------------------ > 1 file changed, 13 insertions(+), 30 deletions(-) > > diff --git a/m4/virt-driver-libxl.m4 b/m4/virt-driver-libxl.m4 > index 8382dc0ec4..2fdeaa506e 100644 > --- a/m4/virt-driver-libxl.m4 > +++ b/m4/virt-driver-libxl.m4 > @@ -31,30 +31,19 @@ AC_DEFUN([LIBVIRT_DRIVER_CHECK_LIBXL], [ > > dnl search for libxl, aka libxenlight > dnl Xen > 4.5 introduced a pkgconfig file, check for it first > - fail=0 > - if test "$with_libxl" != "no" ; then > - PKG_CHECK_MODULES([LIBXL], [xenlight], [ > - LIBXL_FIRMWARE_DIR=`$PKG_CONFIG --variable xenfirmwaredir xenlight` > - LIBXL_EXECBIN_DIR=`$PKG_CONFIG --variable libexec_bin xenlight` > - with_libxl=yes > - ], [LIBXL_FOUND=no]) ... > + old_with_libxl="$with_libxl" > + LIBVIRT_CHECK_PKG([LIBXL], [xenlight], [4.4.0], [true]) Why 4.4.0? The comment above says pkgconfig file was introduced in 4.5 and libvirt requires libxenlight 4.2. So either this check should require libxenlight 4.2.0 (if we are brave and want to check a possible downstream pkgconfig file) or 4.5.0. Jirka -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
