Re: [PATCH v3 3/3] network: Add support for local PTR domains

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/16/2016 01:09 PM, Jiri Denemark wrote:
Similarly to localOnly DNS domain, localPtr attribute can be used to
tell the DNS server not to forward reverse lookups for unknown IPs which
belong to the virtual network.

Signed-off-by: Jiri Denemark <jdenemar@xxxxxxxxxx>
---

Notes:
     Version 3:
     - <ptr> was removed from this patch and will be implemented separately
     - NEWS item
Version 2:
     - RNG schema and tests

  docs/formatnetwork.html.in                      | 21 ++++++++-----
  docs/news.html.in                               |  2 ++
  docs/schemas/network.rng                        |  3 ++
  src/conf/network_conf.c                         | 19 ++++++++++++
  src/conf/network_conf.h                         |  2 ++
  src/network/bridge_driver.c                     | 41 +++++++++++++++++++++++++
  tests/networkxml2confdata/ptr-domains-auto.conf | 20 ++++++++++++
  tests/networkxml2confdata/ptr-domains-auto.xml  | 21 +++++++++++++
  tests/networkxml2conftest.c                     |  1 +
  9 files changed, 123 insertions(+), 7 deletions(-)
  create mode 100644 tests/networkxml2confdata/ptr-domains-auto.conf
  create mode 100644 tests/networkxml2confdata/ptr-domains-auto.xml

diff --git a/docs/formatnetwork.html.in b/docs/formatnetwork.html.in
index 9cf940052..390aa2e0d 100644
--- a/docs/formatnetwork.html.in
+++ b/docs/formatnetwork.html.in
@@ -855,14 +855,14 @@
      &lt;hostname&gt;myhostalias&lt;/hostname&gt;
    &lt;/host&gt;
  &lt;/dns&gt;
-&lt;ip address="192.168.122.1" netmask="255.255.255.0"&gt;
+&lt;ip address="192.168.122.1" netmask="255.255.255.0" localPtr="yes"&gt;
    &lt;dhcp&gt;
      &lt;range start="192.168.122.100" end="192.168.122.254"/&gt;
      &lt;host mac="00:16:3e:77:e2:ed" name="foo.example.com" ip="192.168.122.10"/&gt;
      &lt;host mac="00:16:3e:3e:a9:1a" name="bar.example.com" ip="192.168.122.11"/&gt;
    &lt;/dhcp&gt;
  &lt;/ip&gt;
-&lt;ip family="ipv6" address="2001:db8:ca2:2::1" prefix="64"/&gt;
+&lt;ip family="ipv6" address="2001:db8:ca2:2::1" prefix="64" localPtr="yes"/&gt;
  &lt;route family="ipv6" address="2001:db9:ca1:1::" prefix="64" gateway="2001:db8:ca2:2::2"/&gt;
  </pre>
@@ -983,11 +983,18 @@
          to specify the type of address &mdash; <code>ipv4</code> or
          <code>ipv6</code>; if no <code>family</code> is given,
          <code>ipv4</code> is assumed. More than one address of each family can
-        be defined for a network. The <code>ip</code> element is supported
-        <span class="since">since 0.3.0</span>. IPv6, multiple addresses on a
-        single network, <code>family</code>, and <code>prefix</code> are
-        supported <span class="since">since 0.8.7</span>. The <code>ip</code>
-        element may contain the following elements:
+        be defined for a network. The optional <code>localPtr</code> attribute
+        (<span class="since">since 3.0.0</span>) configures the DNS server not
+        to forward


s/not to forward/to not forward/

Other than that, ACK!

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux