Without a default: case in the switches in xenParseXLDisk(), build would fail with every new disk backend or image format added in libxl, as this is the case in this error: http://logs.test-lab.xenproject.org/osstest/logs/103325/build-amd64-libvirt/5.ts-libvirt-build.log --- src/xenconfig/xen_xl.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/xenconfig/xen_xl.c b/src/xenconfig/xen_xl.c index bcdd35527..f197267bb 100644 --- a/src/xenconfig/xen_xl.c +++ b/src/xenconfig/xen_xl.c @@ -393,6 +393,11 @@ xenParseXLDisk(virConfPtr conf, virDomainDefPtr def) case LIBXL_DISK_FORMAT_EMPTY: break; + + default: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("disk image format not supported: %s"), + libxl_disk_format_to_string(libxldisk->format)); } switch (libxldisk->backend) { @@ -415,6 +420,10 @@ xenParseXLDisk(virConfPtr conf, virDomainDefPtr def) goto fail; virDomainDiskSetType(disk, VIR_STORAGE_TYPE_BLOCK); break; + default: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("disk backend not supported: %s"), + libxl_disk_backend_to_string(libxldisk->backend)); } } -- 2.11.0 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
