On 13.12.2016 11:51, Daniel P. Berrange wrote: > On Tue, Dec 13, 2016 at 11:41:55AM +0100, Michal Privoznik wrote: >> These builds often fails with false positives due to ancient >> compiler found on this system. For instance it fails to see when >> symbol is used as a variable and when it is used as a function >> producing the following warnings: >> >> ../../src/qemu/qemu_monitor_text.c: In function 'parseMemoryStat': >> ../../src/qemu/qemu_monitor_text.c:604: error: declaration of 'stat' shadows a global declaration [-Wshadow] >> /usr/include/sys/stat.h:455: error: shadowed declaration is here [-Wshadow] >> >> Users trying to use libvirt from git on stable system are doomed >> to fix it themselves. > > NACK, CentOS 6 is a supported platform and we need to make sure > we continue to build on there. Working around these compiler warnings > is not hard. I know it is supported but frankly I've never tried running git libvirt there. Do we even know it still works? Otherwise our claim is just an empty promise that we do compile cleanly there. Michal -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
