On Tue, Jun 02, 2009 at 11:05:54AM +0100, Daniel P. Berrange wrote: > The QEMU and UML drivers currently duplicate a non-trivial chunk of NUMA > code. This patch moves it all into src/nodeinfo.c which already has some > other common NUMA code for capabilities initialization. In doing so it > changes the functions to have a common 'nodeXXXX' naming scheme, to avoid > clash with the public APIs using 'virXXXX'. Finally, these central functions > can be directly used in the driver function tables, so we kill off some > pointless wrappers and just add these funtions directly to drivers. Yes the refactoring sounds good and the patch looks fine. ACK, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list