On Thu, Dec 01, 2016 at 09:08:32PM +0800, xieyingtai@xxxxxxxxxx wrote: > From: Yingtai Xie <xieyingtai@xxxxxxxxxx> > > virDomainGetBlockIoTune() will be called before setBlockIoTune, as a result, > it leads to a failure if set flags with VIR_DOMAIN_AFFECT_LIVE | > VIR_DOMAIN_AFFECT_CONFIG which is an reasonable option. > > Signed-off-by: Yingtai Xie <xieyingtai@xxxxxxxxxx> > --- > libvirt-override.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/libvirt-override.c b/libvirt-override.c > index 2de95ce..caa52fb 100644 > --- a/libvirt-override.c > +++ b/libvirt-override.c > @@ -4805,6 +4805,7 @@ libvirt_virDomainSetBlockIoTune(PyObject *self ATTRIBUTE_UNUSED, > Py_ssize_t size = 0; > const char *disk; > unsigned int flags; > + unsigned int flags1 = VIR_DOMAIN_AFFECT_LIVE; This will cause failure if the guest isn't running. > virTypedParameterPtr params = NULL, new_params = NULL; > > if (!PyArg_ParseTuple(args, (char *)"OzOI:virDomainSetBlockIoTune", > @@ -4822,7 +4823,7 @@ libvirt_virDomainSetBlockIoTune(PyObject *self ATTRIBUTE_UNUSED, > } > > LIBVIRT_BEGIN_ALLOW_THREADS; > - i_retval = virDomainGetBlockIoTune(domain, disk, NULL, &nparams, flags); > + i_retval = virDomainGetBlockIoTune(domain, disk, NULL, &nparams, flags1); > LIBVIRT_END_ALLOW_THREADS; > > if (i_retval < 0) > @@ -4838,7 +4839,7 @@ libvirt_virDomainSetBlockIoTune(PyObject *self ATTRIBUTE_UNUSED, > return PyErr_NoMemory(); > > LIBVIRT_BEGIN_ALLOW_THREADS; > - i_retval = virDomainGetBlockIoTune(domain, disk, params, &nparams, flags); > + i_retval = virDomainGetBlockIoTune(domain, disk, params, &nparams, flags1); Just pass in 0 for the flags in both cases Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
