Re: [PATCH 2/2] cpu: Add alternative feature spellings to CPU map

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/29/2016 01:59 PM, Jiri Denemark wrote:
> We can't change feature names for compatibility reasons even if they
> contain typos or other software uses different names for the same
> features. By adding alternative spellings in our CPU map we at least
> allow anyone to grep for them and find the correct libvirt's name.
> 
> Signed-off-by: Jiri Denemark <jdenemar@xxxxxxxxxx>
> ---
>  src/cpu/cpu_map.xml | 28 ++++++++++++++--------------
>  1 file changed, 14 insertions(+), 14 deletions(-)
> 
> diff --git a/src/cpu/cpu_map.xml b/src/cpu/cpu_map.xml
> index 8f366861a..b0233521a 100644
> --- a/src/cpu/cpu_map.xml
> +++ b/src/cpu/cpu_map.xml
> @@ -97,10 +97,10 @@
>      </feature>
>  
>      <!-- standard features, ECX -->
> -    <feature name='pni'>
> +    <feature name='pni'> <!-- sse3 -->
>        <cpuid eax_in='0x01' ecx='0x00000001'/>
>      </feature>

Could we enhance the XML to allow zero or more aliases, as in:

  <feature name='pni'>
    <alias name='sse3'>
    <cpuid ...>
  </feature>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux