Re: [PATCH] qemu: capabilities: Don't partially reprope caps on process reconnect

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 28, 2016 at 10:59:35 +0100, Boris Fiuczynski wrote:
> Peter,
> besides the trivial typo in the subject line (s/reprope/reprobe) I agree
> that this is the correct fix for the capability problem when reconnecting to
> the qemu processes. Thanks.
> 
> I suggest that you mention in the patch description that libvirt starting
> with version 2.2.0 is terminating all running qemu domains if the qemu
> binaries do not implement/have not enabled the qmp command
> 'query-hotpluggable-cpus'.
> Including the user observable internal error message for reference would
> maybe help as well. (internal error: unable to execute QEMU command
> 'query-hotpluggable-cpus': The feature 'query-hotpluggable-cpus' is not
> enabled)

I've already pushed it with the original message, right after Jiri's
review.

> In addition this patch looks to me like a good candidate for the maintenance
> branches.

I've backported it to v2.2-maint. There are no other maint branches
after that.

> 
> Tested-by: Boris Fiuczynski <fiuczy@xxxxxxxxxxxxxxxxxx>

Peter

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux