Re: [PATCH 2/2] security: Implement virSecurityManagerSetHugepages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 22, 2016 at 01:45:43PM +0100, Michal Privoznik wrote:
Since its introduction in 2012 this internal API did nothing. Now
it's finally the right time to put it into a good use. It's
implementation is fairly simple and exactly the same as
virSecurityDomainSetPathLabel.


Then why do you redefine the function?  Why not just say

 .domainSetSecurityHugepages = …DomainSetPathLabel,

or simply:

s/virSecurityManagerDomainSetHugepages/virSecurityManagerDomainSetPathLabel/g

and zap the former function, qemuProcessPrepareHost() is the only caller
anyway.

ACK to any of those two (I prefer the latter).

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux