Re: [PATCH v2 1/2] vbox: change how vbox API is initialized.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2016-11-23 at 11:53 -0500, John Ferlan wrote:
> 
> On 11/23/2016 11:48 AM, Dawid Zamirski wrote:
> 
> Seems our responses crossed paths...  Maybe it'd be best to send a
> v3...
> 
> A couple of other nits I noted were the 2nd-4th arguments to
> virClassNew
> for vboxDriverOnceInit weren't placed under the "virClass" first
> argument (off by a space or two)
> 
> Also the finger twister uninitialize was typed as unintialize in a
> comment and in the commit message as unitialize
> 
> John
> > 
> > Regards,
> > Dawid
> > 

Sure, I'll rework this in v3 and test all the concerns you raised
thoroughly.

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux