On Mon, Nov 14, 2016 at 04:58:19PM +0000, Daniel P. Berrange wrote: > On Mon, Nov 14, 2016 at 05:43:24PM +0100, Michal Privoznik wrote: > > This is just an proof of concept of what has been agreed on here: > > > > https://www.redhat.com/archives/libvir-list/2016-November/msg00285.html > > > > There is still a lot of to be done: > > - set up seclabels > > - implement hot(un-)plug > > - implement other devices, not just disks > > > > I'm sending these in a hope that somebody will at least take a quick look. I'm > > not looking for a code cleanliness (but if you find some issues feel free to > > raise them), more than design confirmation. If I'm going in wrong direction I'd > > rather stop now before digging any deeper. > > I think you're doing broadly the right thing - the only significant problem > is the /dev/pts issue I mention. Oh and we'll need to make sure we skip all this when running qemu:///session since you can't spawn new namespaces as non-root. Not a big deal, since we don't have the udev race problem as non-root either :-) Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list