Re: [PATCH] configure: Prefer /usr/bin over /bin for numad

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 15, 2016 at 02:29:21PM +0100, Guido Günther wrote:
On Debian systems numad gets installed to /usr/bin. However some people
use usrmerge[0] which links /bin to /usr/bin. By changing the lookup
order we make sure the daemon is always found in /usr/bin (with or
without usrmerge installed).

This allows packages built on systems with usrmerge to run on systems
without usrmerge  which would otherwise fail since /bin/numad would be
hardcoded into libvirt.

Originally-Submitted-By: Guilhem Moulin
References: http://bugs.debian.org/843878
[0]: https://packages.debian.org/sid/usrmerge
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 3ff4c42..65bcd4d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1392,7 +1392,7 @@ AC_ARG_WITH([numad],
if test "$with_numad" != "no" ; then
  fail=0

-  AC_PATH_PROG([NUMAD], [numad], [], [/bin:/usr/bin:/usr/sbin])
+  AC_PATH_PROG([NUMAD], [numad], [], [/usr/bin:/bin:/usr/sbin])


Won't the same problem be there with iptables (the first one I saw in
configure.ac) and maybe others?

Also, this should also include $PATH, similarly to *all other* places in
the code =D  It was removed by mistake 11 days after its introduction
4,5 years ago =)

  if test "$with_numad" = "check"; then
    test "$with_numactl" = "yes" || fail=1
--
2.10.2

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]