On Thu, Nov 10, 2016 at 08:58:10 -0500, John Ferlan wrote: > > > On 11/03/2016 02:12 AM, Peter Krempa wrote: > > The memory device alias needs to be treated as machine ABI as qemu is > > using it in the migration stream for section labels. To simplify this > > generate the alias from the slot number unless an existing broken > > configuration is detected. > > > > With this patch the aliases are predictable and even certain > > configurations which would not be migratable previously are fixed. > > > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1359135 > > --- > > src/qemu/qemu_alias.c | 27 ++++++++++++++++++---- > > src/qemu/qemu_alias.h | 3 ++- > > src/qemu/qemu_hotplug.c | 4 +++- > > .../qemuxml2argv-memory-hotplug-dimm-addr.args | 4 ++-- > > 4 files changed, 29 insertions(+), 9 deletions(-) > > > > Revisiting after my face-palm for patch2. > > > diff --git a/src/qemu/qemu_alias.c b/src/qemu/qemu_alias.c > > index 9737158..8521a44 100644 > > --- a/src/qemu/qemu_alias.c > > +++ b/src/qemu/qemu_alias.c > > @@ -332,17 +332,34 @@ qemuAssignDeviceRNGAlias(virDomainDefPtr def, > > } > > > > > > +/** > > + * qemuAssignDeviceMemoryAlias: > > + * @def: domain definition. Necessary only if @oldAlias is true. > > s/old/use (multiple places) I kept using oldAlias, as I think the variable should emphasize that the old approach is used. I can change it if you think otherwise. I will be following up with a patch adding docs for the address anyways. Pushed; Thanks. Peter
Attachment:
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list