Re: [PATCH 2/2] conf: List only online cpus for virsh emulatorpin

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 07, 2016 at 22:39:34 +0530, Nitesh Konkar wrote:
> From: nitesh konkar <niteshkonkar.libvirt@xxxxxxxxx>

Commit message is missing.

> 
> Signed-off-by: Nitesh Konkar <nitkon12@xxxxxxxxxxxxxxxxxx>
> ---
>  src/qemu/qemu_driver.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 38c8414..256d034 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -5435,6 +5435,8 @@ qemuDomainGetEmulatorPinInfo(virDomainPtr dom,
>      } else if (vm->def->placement_mode == VIR_DOMAIN_CPU_PLACEMENT_MODE_AUTO &&
>                 autoCpuset) {
>          cpumask = autoCpuset;
> +    } else if (vm->def->placement_mode == VIR_DOMAIN_CPU_PLACEMENT_MODE_STATIC) {
> +        cpumask = virHostCPUGetOnlineBitmap();

This function is implemented only on linux, thus it breaks on all other
platforms.

Also the returned value needs to be freed, but is leaked in
this case.

Peter

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]