Re: [PATCH 04/17] docs: add footer to all pages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 31, 2016 at 12:41:45PM +0000, Daniel P. Berrange wrote:
Add a footer to all pages containing a blurb about the
code of conduct, and links to social media sites.

Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx>
---
docs/libvirt.css | 44 ++++++++++++++++++++++++++++++++++++++++++++
docs/page.xsl    | 12 ++++++++++++
2 files changed, 56 insertions(+)


diff --git a/docs/page.xsl b/docs/page.xsl
index e3b8d5b..8f6a8c7 100644
--- a/docs/page.xsl
+++ b/docs/page.xsl
@@ -170,6 +170,18 @@
            </form>
          </div>
        </div>
+        <div id="footer">
+          <div id="social">
+            <ul>
+              <li><a href="https://twitter.com/hashtag/libvirt";>twitter</a></li>

This is essentially an ad for twitter. Unless they are sponsoring the
project, it feels out of place here.

+              <li><a href="https://plus.google.com/communities/109522598353007505282";>google plus</a></li>

I presume that community is run by either you or some other libvirt maintainer,
which is what I would expect from such link.

+              <li><a href="http://stackoverflow.com/questions/tagged/libvirt";>stackoverflow</a></li>

This feels like <a href="https://www.google.com/?q=libvirt";>google</a>.

Jan

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]