Re: [PATCH] vshReadlineParse: Remove unused variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 04, 2016 at 09:58:53 +0100, Michal Privoznik wrote:
> After 06a7b1ff4 the @&opts_need_arg is not used anywhere. Well,
> it is set but never read:
> 
> vsh.c: In function 'vshReadlineParse':
> vsh.c:2658:14: warning: variable 'opts_need_arg' set but not used [-Wunused-but-set-variable]
>      uint64_t opts_need_arg, opts_seen;
>               ^~~~~~~~~~~~~
> 
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
>  tools/vsh.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

How about removing the complete function given it's history?

Consider this as an ACK though.

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux