Re: [PATCH] gcrypt: fix build in case we do not use gnutls and gcrypt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 03, 2016 at 04:14:34PM +0300, Olga Krishtal wrote:
> In case when we use any crypt library and gnutls make returns 
> compilation errors.
> 
> Signed-off-by: Olga Krishtal <okrishtal@xxxxxxxxxxxxx>
> ---
>  src/libvirt.c | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/src/libvirt.c b/src/libvirt.c
> index 52462e3..77365d1 100644
> --- a/src/libvirt.c
> +++ b/src/libvirt.c
> @@ -269,7 +269,7 @@ virWinsockInit(void)
>  }
>  #endif
>  
> -
> +#ifdef WITH_GNUTLS
>  #ifdef WITH_GNUTLS_GCRYPT

This doesn't make much sense. The WITH_GNUTLS_GCRYPT should be defined
if-and-only-if  WITH_GNUTLS is defined. If this isn't true, then we
need to fix configure, rather than adding in this extra ifdef check.


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]