Re: [PATCH v4 2/6] conf, qemu: Add newer shmem models

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 02, 2016 at 12:10:21 +0100, Martin Kletzander wrote:
> On Wed, Nov 02, 2016 at 10:45:36AM +0100, Peter Krempa wrote:
> >On Wed, Oct 26, 2016 at 12:51:33 +0200, Martin Kletzander wrote:
> >> The old ivshmem is deprecated in QEMU, so let's use the better
> >> ivshmem-{plain,doorbell} variants instead.
> >>
> >> Signed-off-by: Martin Kletzander <mkletzan@xxxxxxxxxx>
> >> ---
> >>  docs/formatdomain.html.in     | 10 +++++++---
> >>  docs/schemas/domaincommon.rng |  2 ++
> >>  src/conf/domain_conf.c        |  4 +++-
> >>  src/conf/domain_conf.h        |  2 ++
> >>  src/qemu/qemu_command.c       |  7 +++++++
> >>  5 files changed, 21 insertions(+), 4 deletions(-)
> >
> >ACK although it looks like you meant to add stuff from the following
> >commit.
> 
> AAAaaargh, I'll move it _again_... You're right, but if I hadn't had to
> move it the first time...  Anyway, I'll do that.  Thanks.

Well, and why did you move it the first time? :)

Anyways, if you move the XML-XML test part here, and the XML-ARGV part
to the patch where it's actually added then ACK to everything.

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]