On Tue, Nov 01, 2016 at 05:46:07PM +0100, Zeeshan Ali wrote:
> ---
> tests/test-gconfig.c | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/tests/test-gconfig.c b/tests/test-gconfig.c
> index 5389a26..b91f5af 100644
> --- a/tests/test-gconfig.c
> +++ b/tests/test-gconfig.c
> @@ -762,6 +762,26 @@ static void test_domain_device_pci_hostdev(void)
> g_object_unref(G_OBJECT(domain));
> }
>
> +static void test_domain_device_unknown(void)
> +{
> + GVirConfigDomain *domain;
> + GList *devices;
> + GError *error = NULL;
> + char *xml;
> +
> + xml = load_xml("gconfig-domain-device-unknown.xml");
I think you forgot to 'git add' this new XML file.
> +
> + domain = gvir_config_domain_new_from_xml(xml, &error);
> + g_assert_no_error(error);
> +
> + devices = gvir_config_domain_get_devices(domain);
> + g_assert_nonnull(devices);
> +
> + g_list_free(devices);
> + g_object_unref(G_OBJECT(domain));
> +}
> +
> +
> int main(int argc, char **argv)
> {
> gvir_config_init(&argc, &argv);
> @@ -793,6 +813,8 @@ int main(int argc, char **argv)
> test_domain_device_usb_redir);
> g_test_add_func("/libvirt-gconfig/domain-device-pci-hostdev",
> test_domain_device_pci_hostdev);
> + g_test_add_func("/libvirt-gconfig/domain-device-unknown",
> + test_domain_device_unknown);
>
> return g_test_run();
> }
ACK if you fix the missing file when pushing.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list