On Fri, Oct 28, 2016 at 05:09:38PM -0400, John Ferlan wrote: > Commit id 'dcfdf341' passes 'opts_need_arg' and 'opts_seen' to > vshCmddefGetData, but that seems to be incorrect as those values > are not initialized properly (something at least one compiler found). > Instead the static 'const_opts_need_arg' and 'const_opts_seen' values > should be passed. > > By passing unitialized values leads to not finding possible options > for simpler commands (domfsfreeze for example), where if you're in > a virsh shell using command line completion - you'll get a list of > files in your current directory instead of two options --domain and > --mountpoint (as would happen with this patch applied. > > Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx> > --- > tools/vsh.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) ACK Erik
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list